DON'T APPROVE! added model stop for ghg_input with nonsupported radiation options #1936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dudhia
previously approved these changes
Dec 12, 2023
|
Is this one not passing due to some regtest namelists not being consistent with the GHG switch? |
Deleted a blank line to force a reg-test
|
Can someone look at failed checks? |
|
@dudhia |
Added a blank line to trigger reg-test
smileMchen
previously approved these changes
Dec 14, 2023
Commenting out change to see if reg-test will pass
|
This reg-test only passed because the change was commented out. Don't approve it! |
kkeene44
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TYPE: bug fix
KEYWORDS: ghg_input, radiation, module_check_a_mundo
SOURCE: internal
DESCRIPTION OF CHANGES:
Problem:
If a user had ghg_input turned on, but wasn't using one of the supported radiation physics options (i.e., not CAM, RRTM, RRTMG, or RRTMG_fast), the model would give an "ERROR" message, but wouldn't stop, nor would it make any changes to the settings. As long as everything else was correct, it would continue and write out the SUCCESS message at the end of the log files.
Solution:
Added a "count_fatal_error = count_fatal_error + 1" to the check for this in module_check_a_mundo.F.
LIST OF MODIFIED FILES:
M share/module_check_a_mundo.F
TESTS CONDUCTED:
Now, if non-supported radiation options are used with ghg_input, the model stops with the following message:
-- ERROR: ghg_input available only for these radiation schemes: CAM, RRTM, RRTMG, RRTMG_fast
And the LW and SW schemes must be reasonably paired together:
OK = CAM LW with CAM SW
OK = RRTM, RRTMG LW or SW, RRTMG_fast LW or SW may be mixed
-------------- FATAL CALLED ---------------
FATAL CALLED FROM FILE: LINE: 2794
NOTE: 1 namelist settings are wrong. Please check and reset these options
Are the Jenkins tests all passing? Waiting for results.
RELEASE NOTE: A bug fix was added to ensure the model stops when using ghg_input and a non-supported radiation physics option (i.e., anything other than CAM, RRTM, RRTMG, or RRTMG_fast).